> > if ( GET_EQ(ch, i) && isname(name, GET_EQ(ch, i)->name) == 1 ) > Sorry, but I just had to say this: the second part of the if is > a) ugly > b) bad coding > > because isname is definitely a function that should return a bool, being > 0 or non-zero (not 1; -1 is also non-zero... see?) and isname==1 is just > weird to read > > Suggest you change it to (... && isname(..) ) Heh.. okay, that is now the *second* time I've applied a patch to that line of code without bothering to read it. Serves me right. I promise never to blindly apply patches that come in the mail again. :) -j
This archive was generated by hypermail 2b30 : 12/18/00 PST