On Sun, 24 Aug 1997, Andrew Helm wrote: >Since (ptr == ptr->next) will only occur when there's a bug in >another part of the code it's relatively safe not to check for >it. I mean, I'm all for checking just to make sure everything >is the way it "should" be but putting extra checking of that >kind inside loops seems wasteful. So go take out all those 'assert' calls in CircleMUD, they're wasteful too. And take out the if (GET_POS(ch) <= POS_DEAD) in damage() since it will only occur if some other part of the code is buggy. :) Granted they are not in loops but damage() might as well be since it is called constantly in battle. -- greerga@muohio.edu me@null.net | Genius may have its limitations, but stupidity http://www.muohio.edu/~greerga | is not thus handicapped. -- Elbert Hubbard +------------------------------------------------------------+ | Ensure that you have read the CircleMUD Mailing List FAQ: | | http://democracy.queensu.ca/~fletcher/Circle/list-faq.html | +------------------------------------------------------------+
This archive was generated by hypermail 2b30 : 12/08/00 PST