Re: [NEWBIE] [CODE]

From: Fili (cybom@NETROPOLIS.NET)
Date: 12/19/97


Here is what I saw:

Ice wrote:

>  -magic.c:
>  ...                                                  (in mag_effects)
>  case SPELL_STONE_SKIN:
>    af[0].location=APLLY_STR;

Shouldn't this be APPLY_STR

>    af[0].modifier=-30;

Logic error - By casting stone skin your strength goes DOWN?! I think you wanted
APPLY_ARMOR or the like (not sure what it is and I'm too lazy to check. Check it
yourself :) )

>    af[0].duration=24;
>    accum_duration=TRUE;
>    to_vict="Your skin turns to stone.";
>    break;
>
>  case SPELL_STRENGTH:
>    af[0].location=APLLY_STR;

Once again, you want APPLY_STR

>    af[0].duration=(GET_LEVEL(ch)>>1)+4;

Uhhh... isnt >> sh, a command in assembly? I would replace >> with a math function
like /-* or +.

>    af[0].modifier=1+(level>18);

Uhhhh... no. You just said: add 1 to the charactors level which is greater than 18.

>    accum_duration=TRUE;
>    accum_affect=TRUE;
>    to_vict="You feel stronger!";
>    break;

Other than that, I didnt see anything offhand.

Fili


     +------------------------------------------------------------+
     | Ensure that you have read the CircleMUD Mailing List FAQ:  |
     | http://democracy.queensu.ca/~fletcher/Circle/list-faq.html |
     +------------------------------------------------------------+



This archive was generated by hypermail 2b30 : 12/08/00 PST