Re: Latest DG script (pl8) -> BUG?

From: Chris Gilbert (circle@paradox.demon.co.uk)
Date: 07/22/02


On Mon, 2002-07-22 at 09:27, Mathew Earle Reuther wrote:
> As usual, I'm messing with patching DG/OLC etc into current CVS.  When I
> attempt to edit a zone after patching to PL8 DG, I get a "That room does
> not exist."  (Note, this error message comes from oasis.c, in case
> SCMD_OASIS_ZEDIT.)  Note, I *can* create a zone.  I just cannot zedit any
> room.
>
> I fixed this by going back to the way that the previous (PL7) version of
> Oasis handled it, which is like so:
>
>     if ((real_num = real_room(number)) < 0) {
>
> This is what PL8 used:
>
>     if ((real_num = real_room(number)) != NOWHERE) { */
>
> So, have I done something else wrong to get this error?  Or is it actually
> a bug, and != NOWHERE should not have been used in PL8?

Looks like a bug, I think that should actually be:
if ((real_num = real_room(number)) == NOWHERE) {

IE it looks like it's just a typo/bug.

Cheers,
Chris

PS my email address has changed the patch mentions me as having an email
of chris at buzzbee.freeserve.co.uk, but I've moved on in 2 years,
thought I'd sign up again, been meaning to fiddle with the source I've
got lurking 8)  So I'm now only 3 bpl's and a version of dg_scripts
behind, oh and an oasis version 8)

--
   +---------------------------------------------------------------+
   | FAQ: http://qsilver.queensu.ca/~fletchra/Circle/list-faq.html |
   | Archives: http://post.queensu.ca/listserv/wwwarch/circle.html |
   | Newbie List:  http://groups.yahoo.com/group/circle-newbies/   |
   +---------------------------------------------------------------+



This archive was generated by hypermail 2b30 : 06/25/03 PDT