Invalid Names: Here's the bug I found

From: Mathue Moyer (mmoyer@sdcc10.UCSD.EDU)
Date: 01/31/94


Dunno if this is what's wrong with everybody's ban.c,
but it's definitely what was wrong with ours.  If you look at the
end of the file in the function that creates the array of invalid
names, there are (probably) three lines that look like this:

   /* make sure there are no nulls in there */
   for (i = 0; (i < num_invalid) && *invalid_list[i]; i++)
       num_invalid = i-i;

This is very, very silly.  Sets num_invalid to 0, which prevents
the checking function from ever checking against stuff from the
xnames file.  Change it to this (or something like it):

   /* make sure there are no nulls in there */
   for (i = 0; (i < num_invalid) && *invalid_list[i]; i++);
      if (!(*invalid_list[i])) num_invalid = i;

Lemme know if anybody has problems with this not working.  ;)

-Mathue Moyer
-mathue@ucsd.edu



This archive was generated by hypermail 2b30 : 12/07/00 PST