First of all I would like to thank Patrick for this really nice patch that is already running on our MUD (with the correction of PERS(vict,ch) of course...) But while patching (by hand) and modyfing the code to suit our MUD and our language (italian), I asked myself two questions: 1) Don't we need to check if a pointer exists before freeing it ? >+ if(counter==9) { >+ /* then we don't want the old one anymore.. */ >>>> if (GET_TELLS(ch,i)) free(GET_TELLS(ch,counter)); >+ } 2) We need to add in free_char (db.c) a for cycle for freeing the allocated strings previous_tells... Am I right ??? Kabir Coder of DalilaMUD dalila.shopitaly.net 4000 --------------------------------------------------------------- | __ __ __ __ __ __ | | __ ( ) ___ ( ) __ ( \/ ) __ / _) __ ( ) | | / _) /__\ ( ,) )(__ / \ ) ( / \ ( (_ / _) )( | | ( (_ (_)(_) ) \ (____)( () ) (_/\/\_)( () ) \__)( (_ (__) | | \__) (_)\_) \__/ \__/ \__) | | | | mailto: mocci@tin.it | | http://volftp.tin.it/IT/IT/ITALIANI/MOCCI | | http://www.geocities.com/SunsetStrip/Palms/7010 | --------------------------------------------------------------- +------------------------------------------------------------+ | Ensure that you have read the CircleMUD Mailing List FAQ: | | http://democracy.queensu.ca/~fletcher/Circle/list-faq.html | +------------------------------------------------------------+
This archive was generated by hypermail 2b30 : 12/15/00 PST